feat(refresher): add ionEnd event#24526
Closed
WhatsThatItsPat wants to merge 4 commits intoionic-team:mainfrom
Closed
feat(refresher): add ionEnd event#24526WhatsThatItsPat wants to merge 4 commits intoionic-team:mainfrom
WhatsThatItsPat wants to merge 4 commits intoionic-team:mainfrom
Conversation
Member
|
Thanks for your PR! I have a PR to implement this with a few changes (mostly around naming conventions, old vs new), but I've given you co-author credit on the commit: This is planned to go out in v8.8 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build) was run locally and any changes were pushednpm run lint) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number:
#24524
What is the new behavior?
This adds an
ionEndevent as an obverse to theionStartevent.Does this introduce a breaking change?
Other information
This PR appears to work for the web, but I'm not sure if more has to be done for the native refreshers. There are a couple of comments that can be cleaned up after clarification on this.