Skip to content

fix(datetime): fix overlap in datetime-button modal from datetime being too short #31274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
droc101 wants to merge 3 commits into
base: main
Choose a base branch
from
+11 −0
Open

fix(datetime): fix overlap in datetime-button modal from datetime being too short #31274

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
331d518
fix(datetime): fix datetime in datetime-button modal being too short
droc101 Jul 17, 2026
82d894b
fix(datetime): only apply min-height of 350px in ios mode
droc101 Jul 22, 2026
5024d0c
fix(datetime): set min-height on iOS calendar-body to prevent selecti…
droc101 Jul 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions core/src/components/datetime/datetime.ios.scss
View file
Open in desktop

@thetaPC thetaPC Jul 28, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We landed on flooring the row at the circle size instead of setting a height on the calendar body. It keeps the rows collapsible enough to distribute like native, but stops them shrinking under the circle, which is what caused the overlap. This also covers the inline case, not just the overlay.

// datetime.ios.scss

:host .calendar-day-wrapper {
  @include padding(4px);

  // This is required so that the calendar day wrapper
  // will collapse instead of expanding to fill the button
  height: 0;

- min-height: dynamic-font(16px);
+ min-height: calc(#{$datetime-ios-day-height} + 2px);
}

Please also remove the :host .calendar-body { min-height: 282px } rule you added, since this replaces it.

Original file line number Diff line number Diff line change
Expand Up @@ -199,6 +199,17 @@

// Calendar / Body
// -----------------------------------

/**
* In iOS mode the calendar rows are allowed to collapse, so a month
* spanning six week-rows can overlap the selection highlights with
* the default 350px height. This ensures the month view always has
* enough space to not cause overlap.
*/
:host .calendar-body {
min-height: 282px;
}

:host .calendar-body .calendar-month .calendar-month-grid {

/**
Expand Down
Loading