fix(angular): guard transition against destroyed router outlet - #31297
Merged
ShaneK merged 1 commit intoJul 28, 2026
Merged
Conversation
StackController.destroy() sets containerEl to undefined, but a queued transition can resolve after its ion-router-outlet was destroyed (interrupted, re-entrant, or cancelled navigation). The commit guard dereferenced containerEl unconditionally, throwing "TypeError: undefined is not an object (evaluating 'containerEl.commit')" during normal back-navigation. Null-check containerEl so a transition against a destroyed outlet resolves to false instead of crashing. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
@adahlberg-sprocket-sports is attempting to deploy a commit to the Ionic Team on Vercel. A member of the Team first needs to authorize it. |
ShaneK
approved these changes
Jul 28, 2026
Member
|
Thanks for the PR! We've merged it and it'll be deployed in the next update! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #31296
What is the current behavior?
StackController.destroy()setsthis.containerEl = undefined!, but a transition that is still queued behindwait()can resolve after theion-router-outletwas destroyed (interrupted / re-entrant / cancelled navigation during fast back-navigation).transition()then dereferences theundefinedelement atif ((containerEl as any).commit)and throws:Observed at production scale in an Ionic Angular + Capacitor app (several hundred RUM crash events per week from a single build, concentrated on rapid back-navigation between nested outlets).
What is the new behavior?
transition()null-checkscontainerEl(optional chaining) before probing forcommit.false, instead of throwing an unhandledTypeError.Regarding tests: there is no existing unit harness for
StackController(only the e2e test apps), and the defect is a timing race between a queued transition and outlet destruction, which is impractical to reproduce deterministically in e2e. The change is a defensive null-check on a field thatdestroy()explicitly sets toundefined(with a lint-suppressed non-null assertion). We have run this exact guard in production via patch-package: the crash class disappears with no observed regressions.Does this introduce a breaking change?
Other information
The unguarded dereference is present in v8.8.13 through latest stable 8.8.15 and
8.8.16-nightly.20260724.