Skip to content
Navigation Menu
Sign in
Appearance settings
Platform
AI CODE CREATION
GitHub Copilot
Write better code with AI
GitHub Copilot app
Direct agents from issue to merge
MCP Registry
Integrate external tools
DEVELOPER WORKFLOWS
Actions
Automate any workflow
Codespaces
Instant dev environments
Issues
Plan and track work
Code Review
Manage code changes
Code Quality
Enforce quality at merge
APPLICATION SECURITY
GitHub Advanced Security
Find and fix vulnerabilities
Code security
Secure your code as you build
Secret protection
Stop leaks before they start
EXPLORE
Why GitHub
Documentation
Blog
Changelog
Marketplace
View all features
Solutions
BY COMPANY SIZE
Enterprises
Small and medium teams
Startups
Nonprofits
BY USE CASE
App Modernization
DevSecOps
DevOps
CI/CD
View all use cases
BY INDUSTRY
Healthcare
Financial services
Manufacturing
Government
View all industries
View all solutions
Resources
EXPLORE BY TOPIC
AI
Software Development
DevOps
Security
View all topics
EXPLORE BY TYPE
Customer stories
Events & webinars
Ebooks & reports
Business insights
GitHub Skills
SUPPORT & SERVICES
Documentation
Customer support
Community forum
Trust center
Partners
View all resources
Open Source
COMMUNITY
GitHub Sponsors
Fund open source developers
PROGRAMS
Security Lab
Maintainer Community
GitHub Stars
Archive Program
REPOSITORIES
Topics
Trending
Collections
Enterprise
ENTERPRISE SOLUTIONS
Enterprise platform
AI-powered developer platform
AVAILABLE ADD-ONS
GitHub Advanced Security
Enterprise-grade security features
Copilot for Business
Enterprise-grade AI features
Premium Support
Enterprise-grade 24/7 support
Pricing
Search
/
Sign in
Sign up
Appearance settings
You signed in with another tab or window.
Reload
to refresh your session.
You signed out in another tab or window.
Reload
to refresh your session.
You switched accounts on another tab or window.
Reload
to refresh your session.
Dismiss alert
{{ message }}
Uh oh!
There was an error while loading.
Please reload this page
.
ionic-team
/
ionic-framework
Public
Notifications
You must be signed in to change notification settings
Fork
13.3k
Star
52.7k
Code
Issues
560
Pull requests
34
Discussions
Actions
Projects
Wiki
Security and quality
0
Insights
Additional navigation options
Code
Issues
Pull requests
Discussions
Actions
Projects
Wiki
Security and quality
Insights
fix(modal): prevent ion-content collapsing at content-based heights
- #31413
#31413
Merged
brandyscarney
merged 23 commits into
main
ionic-team/ionic-framework:main
from
FW-7731
ionic-team/ionic-framework:FW-7731
Copy head branch name to clipboard
Sep 14, 2026
Conversation
Commits
23
(23)
Checks
Files changed
Merged
fix(modal): prevent ion-content collapsing at content-based heights
#31413
brandyscarney
merged 23 commits into
main
ionic-team/ionic-framework:main
from
FW-7731
ionic-team/ionic-framework:FW-7731
Copy head branch name to clipboard
Commits
Commits on Aug 28, 2026
fix(modal): prevent ion-content collapsing at content-based heights
Show description for 4e8ecc2
brandyscarney
committed
4e8ecc2
View commit details
Copy full SHA for 4e8ecc2
Browse repository at this point
test(modal): add content-height preview test
brandyscarney
committed
e63841c
View commit details
Copy full SHA for e63841c
Browse repository at this point
Commits on Aug 31, 2026
test(modal): reorder modals, don't use ionic buttons
brandyscarney
committed
21e6c23
View commit details
Copy full SHA for 21e6c23
Browse repository at this point
fix(content): watch for changes to --height and respect prefixed values
brandyscarney
committed
51e8923
View commit details
Copy full SHA for 51e8923
Browse repository at this point
test(modal): add e2e tests for various --height values
brandyscarney
committed
54b1596
View commit details
Copy full SHA for 54b1596
Browse repository at this point
Commits on Sep 2, 2026
style: comment the test config
brandyscarney
committed
d5b4e75
View commit details
Copy full SHA for d5b4e75
Browse repository at this point
style: update comment to drop TODO
brandyscarney
committed
7298645
View commit details
Copy full SHA for 7298645
Browse repository at this point
style: update comment to specify the limitation on --height
brandyscarney
committed
6738339
View commit details
Copy full SHA for 6738339
Browse repository at this point
Commits on Sep 8, 2026
fix(content): account for height changes when unmounted
brandyscarney
committed
dff4f83
View commit details
Copy full SHA for dff4f83
Browse repository at this point
test(modal): move styling for red button
brandyscarney
committed
e6da097
View commit details
Copy full SHA for e6da097
Browse repository at this point
fix(content): make --height comparison case-insensitive
brandyscarney
committed
1205cea
View commit details
Copy full SHA for 1205cea
Browse repository at this point
Commits on Sep 9, 2026
refactor(content): move sizeToContent to State
brandyscarney
committed
56dc09f
View commit details
Copy full SHA for 56dc09f
Browse repository at this point
test(modal): remove unused wrappers
brandyscarney
committed
710ca95
View commit details
Copy full SHA for 710ca95
Browse repository at this point
style: remove trailing whitespace
brandyscarney
committed
cf43abf
View commit details
Copy full SHA for cf43abf
Browse repository at this point
fix(content): scope the content-sizing styles to modal
brandyscarney
committed
8873e48
View commit details
Copy full SHA for 8873e48
Browse repository at this point
test(modal): turn off animations for all modals
brandyscarney
committed
7277c15
View commit details
Copy full SHA for 7277c15
Browse repository at this point
test(modal): simplify sampling in the nav overlap test
brandyscarney
committed
839354f
View commit details
Copy full SHA for 839354f
Browse repository at this point
test(modal): cover both modes and add screenshots
brandyscarney
committed
8bfd7d3
View commit details
Copy full SHA for 8bfd7d3
Browse repository at this point
Commits on Sep 10, 2026
refactor(modal): move fullscreen and content logic to overlays
brandyscarney
committed
8a9a5e8
View commit details
Copy full SHA for 8a9a5e8
Browse repository at this point
fix(modal): apply content-sizing when an ancestor updates --height
brandyscarney
committed
3d450d2
View commit details
Copy full SHA for 3d450d2
Browse repository at this point
test(modal): clean up the reusable modal functions
brandyscarney
committed
b9ed932
View commit details
Copy full SHA for b9ed932
Browse repository at this point
Commits on Sep 11, 2026
fix(modal): account for different content-sized modals and safe area
brandyscarney
committed
d56d71c
View commit details
Copy full SHA for d56d71c
Browse repository at this point
test(modal): improve height expectations
brandyscarney
committed
af585a6
View commit details
Copy full SHA for af585a6
Browse repository at this point
You can’t perform that action at this time.