Feature/dname support #296
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit implements comprehensive DNAME (Delegation Name) record support across the entire DIM system: **Core Implementation:** - Added DNAME class to dim/dim/rrtype.py with target field validation - Implemented DNAME-specific validation rules in dim/dim/dns.py: - Prevents DNAME at zone apex (RFC 6672 requirement) - Ensures DNAME cannot coexist with other records at same name (except NS/DS at zone cuts) - Prevents creation of records under DNAME subtrees - Validates that DNAME cannot be created if records exist under the subtree **CLI Support:** - Added DNAME to ndcli command interface in ndcli/dimcli/__init__.py - Added DNAME zone import support in ndcli/dimcli/zoneimport.py - Automatically generates all standard DNAME commands: - create rr <name> dname <target> - delete rr <name> dname [target] - show rr <name> dname [target] - modify rr <name> dname [target] - Zone and zone-profile variants **Testing:** - Created comprehensive functional tests in dim-testsuite/t/rr-create-dname-1.t - Added API unit tests in dim-testsuite/tests/dns_test.py covering: - Basic DNAME creation and deletion - Zone apex restriction validation - Conflict detection with other record types - Subtree validation logic **Documentation:** - Updated API documentation in dim/doc/api.rst - CLI documentation automatically generated from command definitions **PDNS Integration:** - Verified existing pdns-output component already supports DNAME records - Confirmed DNSSEC signing works properly for DNAME records DNAME records provide DNS redirection for entire subtrees, enabling more flexible domain migrations and organizational restructuring compared to CNAME records which only redirect individual names. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PATL, add DNAME support to DIM and ndcli