fix(start): Properly handle xcode-select output#56
Merged
dpogue merged 1 commit intoios-control:masterfrom Nov 7, 2025
Merged
Conversation
erisu
approved these changes
Nov 7, 2025
Contributor
erisu
left a comment
erisu
left a comment
There was a problem hiding this comment.
LGTM, tested and confirmed the simulator app is opening.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
spawnSyncstdiois a Buffer, not a string, and a bunch of APIs are apparently happy to handle that (but specifically notpath.join). Passingencoding: "utf8"ensures that the output is a UTF-8 string rather than a buffer.xcode-select -phas a trailing newline that needs to be stripped before using it to build a path (this was previously masked by using bash backtick interpolation, which automatically strips newlines)