coreiface: deprecate DhtAPI in favor of RoutingAPI#461
Draft
Conversation
Codecov Report
@@ Coverage Diff @@
## main #461 +/- ##
==========================================
- Coverage 66.47% 66.44% -0.04%
==========================================
Files 207 207
Lines 24681 24681
==========================================
- Hits 16407 16399 -8
- Misses 6851 6858 +7
- Partials 1423 1424 +1 |
aschmahmann
requested changes
Sep 5, 2023
Contributor
aschmahmann
left a comment
aschmahmann
left a comment
There was a problem hiding this comment.
There's a bunch of go-check errors around using the wrong types. After fixing that things look pretty good.
| FindPeer(context.Context, peer.ID) (peer.AddrInfo, error) | ||
|
|
||
| // FindProviders finds peers in the DHT who can provide a specific value given a key. | ||
| FindProviders(context.Context, path.Path, ...options.DhtFindProvidersOption) (<-chan peer.AddrInfo, error) |
| FindProviders(context.Context, path.Path, ...options.DhtFindProvidersOption) (<-chan peer.AddrInfo, error) | ||
|
|
||
| // Provide announces to the network that you are providing given values. | ||
| Provide(context.Context, path.Path, ...options.DhtProvideOption) error |
|
|
||
| time.Sleep(3 * time.Second) | ||
|
|
||
| out, err := apis[2].Routing().FindProviders(ctx, p, options.Dht.NumProviders(1)) |
Contributor
|
@Jorropo why skip changelog here? We're deprecating an API. No we're not removing it or anything but seems reasonable to mention. |
Contributor
Author
|
Good question, the API was already deprecated in Kubo and I had tunnel vision. |
Member
|
Triage notes:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.