feat: TxnDatastore namespace and keytransform wrappers#210
feat: TxnDatastore namespace and keytransform wrappers#210i-norden wants to merge 8 commits intoipfs:masterfrom
Conversation
|
Thank you for submitting this PR!
Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution. |
|
@i-norden I don't see much has changed since last time? |
Ah apologies, I embedded but with a named field instead of anonymously so it still had the methods reimplemented but only to fall directly through. Fixed now! |
|
Also embedded |
|
@i-norden I'm not going to have much time in the next few days, but have a look to #211. I think it does what you want. You don't need to re-implement anything, you just need to wrap stuff in other stuff. If I haven't done something completely wrong, just take that, improving the naming of things and test it a bit. |
|
Thanks @hsanjuan! I appreciate the feedback. I'll take a look and test out that wrapper. |
|
@i-norden is this PR still necessary or were you able to solve it with mentioned wrapper? |
This PR introduces namespace and keytransform wrappers for the go-datastore
TxnDatastore. This is in order to support aGetManyboxo blockstore implementation that leverages theTxnDatastorefor batched reads which, in turn, is ultimately for supporting parallel traversal methods in go-hamt-ipld and go-amt-ipld.boxo/blockstore PR that uses this: ipfs/boxo#492