Skip to content

fix: add warning for incorrect packed option usage #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
achingbrain merged 2 commits into from
Sep 18, 2026
Merged

fix: add warning for incorrect packed option usage #208

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
10716a7
fix: add warning for incorrect packed option usage
achingbrain Sep 18, 2026
6350c11
chore: linting
achingbrain Sep 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions packages/protons/src/fields/field.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,30 @@ export class Field implements MessageField {
console.info(`[WARN] ${message}`)
}
}

if (parent.def.edition === 'proto2') {
if (def.options?.features?.repeated_field_encoding != null) {
const message = `field "${name}" has the features.repeated_field_encoding=${def.options.features.repeated_field_encoding} option, this is unsupported in proto2. Please use packed=${def.options?.features?.repeated_field_encoding === 'PACKED'} instead - see https://protobuf.dev/editions/features/#repeated_field_encoding`

if (parent.flags?.strict === true) {
throw new ParseError(message)
} else {
// eslint-disable-next-line no-console
console.info(`[WARN] ${message}`)
}
}
} else {
if (def.options?.packed != null) {
const message = `field "${name}" has the packed=${def.options.packed} option, this is unsupported in edition="${parent.def.edition}". Please use features.repeated_field_encoding=${def.options?.packed === true ? 'PACKED' : 'EXPANDED'} instead - see https://protobuf.dev/editions/features/#repeated_field_encoding`

if (parent.flags?.strict === true) {
throw new ParseError(message)
} else {
// eslint-disable-next-line no-console
console.info(`[WARN] ${message}`)
}
}
}
}

getDecoderInterfaceField (parent: Parent, indent = ''): string {
Expand Down
Loading