pass cell_meta from do_execute to run_cell#1475
Merged
Merged
Conversation
erawn
changed the title
for more information, see https://pre-commit.ci
erawn
changed the title
P4X-ng
approved these changes
Jan 10, 2026
Collaborator
|
Can you rebase this on |
ianthomas23
approved these changes
Mar 10, 2026
ianthomas23
left a comment
ianthomas23
left a comment
Collaborator
There was a problem hiding this comment.
Thanks @erawn
There are some linting and docs errors but I will merge it now and fix the errors myself afterwards, as you have been waiting quite a while for this to be accepted.
Contributor
Author
|
Thank you so much @ianthomas23 ! Apologies for missing your earlier message, and thanks for handling it anyways! |
This was referenced Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Other half of ipython/ipython#15071
In order to avoid an
if-elif-elif-elsesequence I copied the strategy already used forexecute_requestand made a list of the arguments rather than conditioning different method calls. Happy to switch it back or do something else if others prefer a different style.