Repository navigation
Add the kinematics metrics #92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bokalnv
wants to merge
40
commits into
main
Choose a base branch
from
bokal/feat/metrics-kinematics
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
40 commits
Select commit
Hold shift + click to select a range
a058fd8
feat: record metric inputs and run metadata during generation
bokalnv 96a15bd
docs: describe what generation records per step, attempt and run
bokalnv 5f3264b
feat: add the autodata_metrics registry and the run report
bokalnv 2a5d495
docs: add the metrics reference page with a table generated from the …
bokalnv 5303c8f
fix: keep earlier runs' records and label only this run's datasets
bokalnv a2006af
Merge the PR #84 fixes into the metrics framework
bokalnv 9ca575b
fix: report a run from the attempt log of the dataset's own run
bokalnv 5948fc0
docs: say the result file and attempt log come with --result_file
bokalnv 729ffc7
Merge the PR #84 docs fix into the metrics framework
bokalnv 77b511d
feat: make metric recording opt-in and keep algorithm diagnostics in …
bokalnv d147c48
Merge the opt-in metric recording from PR #84
bokalnv ca4a948
fix: reject non-finite values, require --report for report options, r…
bokalnv 9ea6a76
fix: record metric inputs with a custom recorder and without a succes…
bokalnv 4f6e1ab
Merge the recorder fixes from PR #84
bokalnv 44a57b8
Merge main after PR #84
bokalnv c632ff6
feat: add episode checks and validity metrics
bokalnv 2bd8352
fix: check the attempt log against its result and keep reports valid …
bokalnv f205d26
Merge the review fixes from #90
bokalnv 45d5ca4
refactor: compute baselines on the source as is and share the docs ta…
bokalnv 475e598
fix: refuse a source other than the run's and non-finite gate bounds
bokalnv 7e84d20
Merge the source and gate-bound checks from #90
bokalnv 3d4f435
fix: require scalar gate bounds and qualify the source check in the docs
bokalnv f0111a3
Merge the gate-bound and docs fixes from #90
bokalnv fc8e3a8
Merge main after #90
bokalnv 573e049
fix: warn about a dataset without an autodata entry only against a ru…
bokalnv 1a591f2
feat: summarize the metrics report on the console and time annotation…
bokalnv 19cd660
fix: tighten the episode checks and require valid episodes in the e2e…
bokalnv b3b2d9a
Merge the episode-check fixes from #91
bokalnv 9cbd00a
refactor: derive skipped checks from the check groups and trim the su…
bokalnv b9c9d5b
fix: report degenerate data instead of failing on it
bokalnv 622af85
fix: keep the report and its summary whole on malformed metric output…
bokalnv 1b74d5b
fix: refuse corrupt run metadata and malformed gate files
bokalnv 88446f0
refactor: parse every record the report reads against one declared shape
bokalnv 1545450
feat: add the kinematics metrics
bokalnv 1cc004c
fix: check subtask signals and pose shapes, and time frozen frames
bokalnv 283db69
Merge branch 'bokal/feat/metrics-validity' into bokal/feat/metrics-ki…
bokalnv 2424192
Merge remote-tracking branch 'origin/main' into bokal/feat/metrics-ki…
bokalnv 8ec9ce9
fix: merge baseline limits by kind and reject pose slices beyond the …
bokalnv 722c781
fix: fill in every nested record of a baseline entry from the run
bokalnv feefa22
fix: keep a source's pose-action layout whole in its baseline
bokalnv File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.