Skip to content

Isolate maple table background#786

Open
xyao-nv wants to merge 3 commits into
mainfrom
xyao/fix/maple_table_asset
Open

Isolate maple table background#786
xyao-nv wants to merge 3 commits into
mainfrom
xyao/fix/maple_table_asset

Conversation

@xyao-nv

@xyao-nv xyao-nv commented Jun 11, 2026

Copy link
Copy Markdown
Collaborator

Summary

Before:
Arena/assets/object_library/srl_robolab_assets/scenes/maple_table_robolab.usda
(will be removed from OV once this MR is merged)

After:
maple table background: Arena/assets/object_library/srl_robolab_assets/scenes/maple_table.usda
robot stand added in droid.py: Arena/assets/object_library/srl_robolab_assets/robots/franka_stand_grey.usda

Screenshot from 2026-06-11 22-53-15

@xyao-nv xyao-nv marked this pull request as ready for review June 12, 2026 00:45
@greptile-apps

greptile-apps Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR isolates the maple table background into a standalone USD asset and replaces the generic Isaac stand in droid.py with a purpose-built franka_stand_grey.usda from the Nucleus asset library.

  • background_library.py: Updates MapleTableRobolab.usd_path from the old combined scene (maple_table_background.usda) to the new isolated background asset (maple_table.usda).
  • droid.py: Swaps the robot stand from the remote S3-hosted stand_instanceable.usd to the internal Nucleus-hosted franka_stand_grey.usda, retaining the existing scale=(1.2, 1.2, 1.7) and activate_contact_sensors=False.

Confidence Score: 5/5

Both changes are asset path swaps with no logic modifications; safe to merge once the new USD files are confirmed present at their Nucleus paths.

The changes replace two USD asset paths — a straightforward refactor with no impact on simulation logic, physics settings, or configuration contracts. The main open questions (physics properties and scale fit for the new stand) were already raised in prior review comments and are non-blocking.

No files require special attention beyond verifying the new USD assets exist on Nucleus at the declared paths.

Important Files Changed

Filename Overview
isaaclab_arena/assets/background_library.py Simple one-line path rename from maple_table_background.usda to maple_table.usda; no logic changes.
isaaclab_arena/embodiments/droid/droid.py Replaces the remote S3 generic stand with the internal Nucleus franka_stand_grey.usda; scale and other spawn settings are unchanged from the previous asset.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[MapleTableRobolab] -->|usd_path| B["NUCLEUS/.../scenes/maple_table.usda\n(was: maple_table_background.usda)"]
    
    C[DroidSceneCfg.stand] -->|usd_path| D["NUCLEUS/.../robots/franka_stand_grey.usda\n(was: S3 Isaac stand_instanceable.usd)"]
    D --> E["scale=(1.2, 1.2, 1.7)\nactivate_contact_sensors=False"]
Loading

Reviews (2): Last reviewed commit: "lint" | Re-trigger Greptile

@xyao-nv xyao-nv force-pushed the xyao/fix/maple_table_asset branch from 2e50ced to 17337e0 Compare June 12, 2026 05:53

@cvolkcvolk cvolkcvolk left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants