docs(theme): serve GLightbox and the CC badge from the site itself - #136
Merged
Merged
Conversation
Privacy Badger flagged two third-party hosts on iscc.codes: - unpkg.com: Zensical's bundle fetches GLightbox from there unless the global is already defined. The theme now ships GLightbox 3.3.1 (MIT) under assets/iscc/vendor/ and loads it on pages whose content carries lightbox anchors, before the bundle runs. - i.creativecommons.org: the CC BY badge on the License page and the legacy specification was hot-linked. It is now docs/images/cc-by-4.0.svg, marked off-glb so it stays out of the lightbox. The third hit, fonts.googleapis.com, comes from the iscc.ai chat widget's theme.json and is fixed on the iscc.ai side. Pre-commit hooks leave the vendored files verbatim, the theme README documents the no-third-party-requests rule, and the docs ISCC-SUM stamp is regenerated for the added badge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Privacy Badger flagged three third-party hosts on iscc.codes. Two are fixed here; the third is fixed on the iscc.ai side.
Changes
zensical_iscc/assets/iscc/vendor/glightbox/and loads it in the head on pages whose content carries lightbox anchors, before the bundle runs. The template only sees a stripped config without the plugin key, so detection is by page content.docs/images/cc-by-4.0.svg, markedoff-glbso it stays out of the lightbox.public/theme.json; iscc.ai now self-hosts those fonts (separate change, pending deploy there).navigation.instantcaveats), and the docs ISCC-SUM stamp is regenerated for the added badge.Verification
prek run --all-files,check_site_paths.py,zensical build --clean,gen_markdown_pages.pyand the site-dir path check pass.Merge note
Both this PR and #135 regenerate the ISCC-SUM stamp line in
docs/license.md; whichever merges second needs one rerun of the prek stamp hook.