Skip to content

Document IndexedDB delete/read sync boundary #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
issackjohn wants to merge 1 commit into
base: responsive-design
Choose a base branch
from
Open

Document IndexedDB delete/read sync boundary #56

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion experimental/javascript-wc-indexeddb/dist/src/workload-test.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,13 @@ const suites = {
const item = items[i].shadowRoot.querySelector(".remove-todo-button");
item.click();
}
if (j < 9) {
if (j < numberOfIterations - 1) {
// moveToPreviousPage() dispatches previous-page-loaded only
// after the storage read for the previous page completes.
// The read fetches lower item numbers than the page just
// deleted, so it does not race those pending delete writes.
// FinishDeletingItemsFromDB still waits for all deletes
// before the suite advances.
const previousPageButton = document.querySelector("todo-app").shadowRoot.querySelector("todo-bottombar").shadowRoot.querySelector(".previous-page-button");
previousPageButton.click();
await iterationFinishedPromise;
Expand Down
8 changes: 7 additions & 1 deletion experimental/javascript-wc-indexeddb/src/workload-test.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,13 @@ const suites = {
const item = items[i].shadowRoot.querySelector(".remove-todo-button");
item.click();
}
if (j < 9) {
if (j < numberOfIterations - 1) {
// moveToPreviousPage() dispatches previous-page-loaded only
// after the storage read for the previous page completes.
// The read fetches lower item numbers than the page just
// deleted, so it does not race those pending delete writes.
// FinishDeletingItemsFromDB still waits for all deletes
// before the suite advances.
const previousPageButton = document.querySelector("todo-app").shadowRoot.querySelector("todo-bottombar").shadowRoot.querySelector(".previous-page-button");
previousPageButton.click();
await iterationFinishedPromise;
Expand Down
Loading