virtualservice: change the directResponse.body.bytes format to byte
#3606
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
😊 Welcome @dgn! This is either your first contribution to the Istio api repo, or it's been You can learn more about the Istio working groups, Code of Conduct, and contribution guidelines Thanks for contributing! Courtesy of your friendly welcome wagon. |
istio-testing
added
the
size/XS
dgn
added
the
release-notes-none
Contributor
Author
|
/retest |
dgn
force-pushed
the
fix-binary-format
branch
from
26204eb to
fb6e837
Compare
dgn
removed
the
release-notes-none
istio-testing
added
size/S
5 tasks
howardjohn
reviewed
Dec 2, 2025
Member
howardjohn
left a comment
howardjohn
left a comment
There was a problem hiding this comment.
We should probably fix this at the source if binary is never valid
cmd/protoc-gen-crd/openapiGenerator.go
810- case descriptor.FieldDescriptorProto_TYPE_BYTES:
811- schema.Type = "string"
812: schema.Format = "binary"
813- schema.Description = g.generateDescription(field)
from istio/tools
| string string = 1; | ||
|
|
||
| // response body as base64 encoded bytes. | ||
| // +kubebuilder:validation:Format=byte |
Member
There was a problem hiding this comment.
huh, in the current CRD do we really force users to base64 encode it?
Contributor
Author
Thanks for the pointer. See istio/tools#3315 for a fix |
dgn
force-pushed
the
fix-binary-format
branch
from
fb6e837 to
a9efd5d
Compare
istio-testing
added
size/XS
istio-testing
added
size/S
Contributor
Author
|
/retest |
dgn
force-pushed
the
fix-binary-format
branch
from
252e275 to
a9efd5d
Compare
istio-testing
added
size/XS
According to our documentation, base64-encoded values should be used in this field, in which case `byte` is the correct format rather than `binary`.
dgn
force-pushed
the
fix-binary-format
branch
from
a9efd5d to
89e774a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to our documentation, base64-encoded values should be used in this field, in which case
byteis the correct format rather thanbinary. In fact,binarymakes no sense as there's no way input raw binary data into CRDs/etcd. It is also not one of the allowed formats in CustomResourceDefinitions.As of K8s 1.34+, installing the VirtualService CRD will output a warning about this:
Fixes istio/istio#58461