Fix backup and restore reliability bugs - #31
Draft
itbm wants to merge 1 commit into
Draft
Conversation
Address S3 checksum failures, leftover dump files, ash-incompatible tests, UTC timestamps, PBKDF2 encryption with legacy decrypt fallback, dump-only pg options, configurable cron timeout, overlapping schedule skips, and safer SQL identifier quoting. Co-authored-by: itbm <itbm@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the reliability bugs identified in review (except the intentional dual image names).
Changes
AWS_REQUEST_CHECKSUM_CALCULATION/AWS_RESPONSE_CHECKSUM_VALIDATIONtowhen_requiredto avoidXAmzContentSHA256Mismatchwith AWS CLI v2 / S3-compatible stores/tmpand remove them after upload (and on failure via trap)[[ … ]]/==with POSIXcase/=so scripts work under Alpine BusyBox ashdate -uso theZsuffix is accuratePOSTGRES_EXTRA_DUMP_OPTS— dump-only flags forpg_dump/pg_dumpallwithout affecting restore clientsCOMMAND_TIMEOUT(goduration, e.g.2h)DROP/CREATE DATABASEDocs
Test plan
dash -nonbackup.sh,restore.sh,run.shgo buildforgo-cron@every 1s