Skip to content

Show only filled nodes in the data tree#62

Open
mfiaudrin-epsyl wants to merge 2 commits into
iterorganization:feature/show-only-filled-nodesfrom
mfiaudrin-epsyl:feature/show_only_filled_nodes
Open

Show only filled nodes in the data tree#62
mfiaudrin-epsyl wants to merge 2 commits into
iterorganization:feature/show-only-filled-nodesfrom
mfiaudrin-epsyl:feature/show_only_filled_nodes

Conversation

@mfiaudrin-epsyl
Copy link
Copy Markdown
Collaborator

This feature from FE allow to receive data provided by BE (attributes has_data) when fetching data from ids_info/node_info.

It also filter received nodes to only show them having data in the tree.

@mfiaudrin-epsyl mfiaudrin-epsyl changed the title Get has_data attribute and keep only nodes with data Show only filled nodes in the data tree May 13, 2026
@mfiaudrin-epsyl
Copy link
Copy Markdown
Collaborator Author

Hello @olivhoenen,
I have updated the filter condition to display only the nodes having has_data equals to true or null (instead of only true before). So that only them having false will be hidden.
The feature is ready to be reviewed

@mfiaudrin-epsyl
Copy link
Copy Markdown
Collaborator Author

Hello @jwasikpsnc,
To allow @olivhoenen to test our functionnality, do you recommend to approve this PR and merge it into https://github.com/iterorganization/IBEX/tree/feature/show-only-filled-nodes in order to test it in your branch or it should be tested directly here ?
I ask this because in order to have has_data information from BE there is a manipulation to do before launching the application. I don't know if @olivhoenen know what should be done.
Thanks !

@jwasikpsnc
Copy link
Copy Markdown
Collaborator

We can test it here, so in case IO request changes in FE, you can push them easily.

@olivhoenen
If it make it easier for you to test the feature, here are steps i have followed to run IBEX on imas_core::develop:

  1. Comment line 32,36 and 37 in launch-dev.sh
image
  1. module load GCCcore/13.3.0 CMake/3.31.8 Saxon-HE/12.9-Java-25 Boost/1.83.0-GCC-13.2.0 HDF5/1.14.3-iimpi-2023b Python UDA/2.9.3-GCC-13.2.0 nodejs
  2. python -m venv imas_core_develop_venv
  3. . imas_core_develop_venv/bin/activate
  4. pip install 'imas-core @ git+https://github.com/iterorganization/imas-core.git@develop' 'imas-python @ git+https://github.com/iterorganization/imas-python@develop'
  5. ./launch-dev.sh

name: string;
ndim: number;
type: NodeInfoTypeEnum;
has_data: boolean;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As has_data is defaulted to None, shall it be:

Suggested change
has_data: boolean;
has_data: boolean | null;

(same for NodeInfoResponse)

Copy link
Copy Markdown
Contributor

@olivhoenen olivhoenen May 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The feature looks good and works as expected, thanks @mfiaudrin-epsyl and @jwasikpsnc.

The only issue I've noticed, but I believe this may not be related to this PR (as I believe the problem is also present in #55 ), is that the search functionality does not work properly anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants