Skip to content

Fix-HDF5-buffered-reads-and-writes-for-shape-datasets #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
prasad-sawantdesai wants to merge 2 commits into
base: develop
Choose a base branch
from
Draft

Fix-HDF5-buffered-reads-and-writes-for-shape-datasets #52

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
706c8cc
raise exception when rank mismatch instead of segfaulting
prasad-sawantdesai May 22, 2026
dfa8dab
fixed message
prasad-sawantdesai May 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions src/hdf5/hdf5_reader.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1288,6 +1288,18 @@ int HDF5Reader::readPersistentShapes_Get(Context *ctx, hid_t gid, const std::str
new_data_set->open(tensorized_path.c_str(), gid, &dataset_id, 1, nullptr, alconst::integer_data, true, true, dec->getURI());
if (!(new_data_set->dataset_id >= 0))
throw ALBackendException("HDF5Backend: unexpected dataset_id value in HDF5Reader::readPersistentShapes_Get()", LOG);

{
int shape_rank = new_data_set->getRank();
int expected_rank = static_cast<int>(current_arrctx_indices.size()) + 1;
if (shape_rank != expected_rank) {
throw ALBackendException(
"HDF5Backend: SHAPE dataset '" + tensorized_path
+ "' has rank " + std::to_string(shape_rank)
+ " but rank " + std::to_string(expected_rank) + " was expected. ",
LOG);
}
}
*dataset_id_shapes = dataset_id;
int dim = -1;
auto hsSelectionReader = std::unique_ptr<HDF5HsSelectionReader>(new HDF5HsSelectionReader(new_data_set->getRank(), new_data_set->dataset_id,
Expand Down Expand Up @@ -1325,6 +1337,18 @@ int HDF5Reader::readPersistentShapes_GetSlice(Context *ctx,
DataEntryContext *dec = getDataEntryContext(ctx);
std::unique_ptr<HDF5DataSetHandler> new_data_set(new HDF5DataSetHandler(false, dec->getURI()));
new_data_set->open(tensorized_path.c_str(), gid, &dataset_id, 1, nullptr, alconst::integer_data, true, true, dec->getURI());

{
int shape_rank = new_data_set->getRank();
int expected_rank = static_cast<int>(aos_indices.size()) + 1;
if (shape_rank != expected_rank) {
throw ALBackendException(
"HDF5Backend: SHAPE dataset '" + tensorized_path
+ "' has rank " + std::to_string(shape_rank)
+ " but rank " + std::to_string(expected_rank) + " was expected. ",
LOG);
}
}
int dim = -1;
auto hsSelectionReader = std::unique_ptr<HDF5HsSelectionReader>(new HDF5HsSelectionReader(new_data_set->getRank(), dataset_id,
new_data_set->getDataSpace(), new_data_set->getLargestDims(), alconst::integer_data, aos_indices.size(), &dim));
Expand Down
Loading