Fix NICE direct mode#166
Open
SBlokhuizen wants to merge 2 commits into
Open
Conversation
SBlokhuizen
requested review from
MireilleSchneider and
maarten-ic
as code owners
maarten-ic
reviewed
May 22, 2026
Collaborator
maarten-ic
left a comment
maarten-ic
left a comment
There was a problem hiding this comment.
Code looks good, some questions on edge cases:
Comment on lines
+23
to
+25
| <algoStartFromScratch>0</algoStartFromScratch> | ||
| <algoStartFromScratchReconAB>0</algoStartFromScratchReconAB> | ||
| <algoStartPsiFromInData>1</algoStartPsiFromInData> |
Collaborator
There was a problem hiding this comment.
What does NICE do if there is no 2D psi grid available in the input equilibrium IDS?
|
|
||
| # Load previous equilibrium from communicator output if available | ||
| if self.communicator.equilibrium is not None: | ||
| equilibrium = self.communicator.equilibrium |
Collaborator
There was a problem hiding this comment.
This is only valid if both runs use the same machine description, right?
| equilibrium = self._create_equilibrium() | ||
|
|
||
| # Load previous equilibrium from communicator output if available | ||
| if self.communicator.equilibrium is not None: |
Collaborator
There was a problem hiding this comment.
What should a user do if the previous run did not converge?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This uses the equilibrium IDS from a previous run as input for a subsequent run. This allows NICE direct mode to be used with the following workflow: