refactoring/536_Resolve_Sonar_cloud_findings by redcatbear · Pull Request #539 · itsallcode/openfasttrace

redcatbear · 2026-06-03T13:03:22Z

This is part 2 of the solution for #536. After the local Sonar findings are addressed, we now work on the SonarCloud findings.

Contributes to #536.

…IdMatcher.java

….java

sonarqubecloud · 2026-06-04T17:49:08Z

Quality Gate failed

Failed conditions
60.2% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

kaklakariada · 2026-06-05T09:00:04Z

-        result = prime * result + (this.withoutTags ? 1231 : 1237);
-        result = prime * result + ((this.tags == null) ? 0 : this.tags.hashCode());
-        return result;
+        return Objects.hash(this.artifactTypes, this.tags, this.withoutTags);


Only mentioned once: check if a Test with equalsverifier exists

Junie says:

No classes were found that override equals and/or hashCode but lack a matching EqualsVerifier unit test. All identified classes that implement these methods are already covered by EqualsVerifier.

kaklakariada · 2026-06-05T09:01:14Z

     */
    public Set<String> getArtifactTypes()
    {
-        return this.artifactTypes;


Is this necessary when the builder already makes the list unmodifiable?
Only mentioned once.

You are right. Should only be done once in the builder.

kaklakariada · 2026-06-05T09:01:48Z

        public Builder artifactTypes(final Set<String> artifactTypes)
        {
-            this.artifactTypes = artifactTypes;
+            this.artifactTypes = Collections.unmodifiableSet(artifactTypes);


Better create a defensive copy. Only mentioned once.

kaklakariada · 2026-06-05T09:27:14Z

    public Map<LinkStatus, List<LinkedSpecificationItem>> getLinks()
    {
-        return this.links;
+        return new EnumMap<>(this.links);


Make immutable

This one is tricky, since there is a bidirectional linking mechanism in the way.
Create issue #540.

kaklakariada · 2026-06-05T13:27:40Z

        }
        catch (final ClassNotFoundException ignore)
        {
+            LOGGER.log(Level.FINEST, () -> "Unable to find class " + name + " with child logger."


Classloader, not logger.
Add classloader names to log Message

kaklakariada · 2026-06-05T13:30:13Z


        final SpecificationListBuilder builder = this.builderArg.getValue();
-        assertThat(result, sameInstance(builder.build()));
+        assertThat(result, equalTo(builder.build()));


Ensure that model class is tested with equalsverifier

SpecificationItem has that test.

kaklakariada · 2026-06-05T13:34:37Z

@@ -49,7 +50,7 @@ private void processLine(final LineConsumer consumer, final int currentLineNumbe
        catch (final Exception exception)


Maybe catching runtimeexception is enough here? Then you can avoid the suppression.

…ric wildcard parameter in AbstractLightWeightMarkupImporterTest.

…ilders do it already.

redcatbear added 2 commits June 3, 2026 09:27

#536: Resolve Sonar findings of June 2026 up to Linker.java

cb20e2c

#536: Resolve Sonar findings of June 2026 up to TestSpecificationItem…

73734c9

…IdMatcher.java

redcatbear self-assigned this Jun 3, 2026

redcatbear added the refactoring Code improvement without behavior change label Jun 3, 2026

redcatbear added 11 commits June 3, 2026 15:23

Merge branch 'main' into refactoring/536_Resolve_Sonar_cloud_findings

59b9901

#536: Resolve Sonar findings of June 2026 up to TestSpecificationItem…

2e8ec57

…IdMatcher.java

#536: Resolve Sonar findings of June 2026 up to ExporterFactory.java

b8cf02f

#536: Resolve Sonar findings of June 2026 up to MultiFileImporterImpl…

d2b714b

….java

#536: Resolve Sonar findings of June 2026 up to SpecificationItemId.java

f8fb51e

#536: Maded pattern private in PlainTextReport.

b125ad5

#536: Up to TextFormatterFactory.

08b616a

#536: Up to ZipFileImporter.

ed28a94

#536: Wrapped overlong line.

af6f33e

#536: Added missing curly braces.

710fd99

#536: Fixed some more Sonar findings.

07636a5

kaklakariada requested changes Jun 5, 2026

View reviewed changes

redcatbear added 4 commits June 5, 2026 17:28

#536: Added suppression for S4968 when Hamcrest Matcher requires gene…

22ef28e

…ric wildcard parameter in AbstractLightWeightMarkupImporterTest.

#536: Removed redundant unmodifiable wrappers for collections. The bu…

c486d37

…ilders do it already.

#536: Fixed review findings of @kaklakariada.

f3ed0b8

#536: Added missing method return type.

c34e8c8

		@@ -49,7 +50,7 @@ private void processLine(final LineConsumer consumer, final int currentLineNumbe
		catch (final Exception exception)

Conversation

redcatbear commented Jun 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sonarqubecloud Bot commented Jun 4, 2026

Quality Gate failed

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

redcatbear commented Jun 3, 2026 •

edited

Loading