Closed
Conversation
Owner
|
Hey @powlaa, thanks for the PR. A few thoughts: Now as for the API design, exposing these internals increase our API by a lot, which limits future refactoring (without breaking changes). I wonder if having a specific configuration for this would work better. Cheers |
Owner
|
Closing for now. ✌️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Description
Adds support for providing a custom graph model input so that the task can be extended to render a custom graph. Previously, the plugin only allowed generation of graphs based on the detected module relationships within a Gradle project.
To enable this, I have changed the visibility from
internaltopublicfor:graphModelsandprojectDirectorysince these are the fields that need to be setModuleandGraphParseResultto allow import of these classes in order to create the necessary data structureGraphConfig.Builder.build()to enable creation of aGraphConfigobject📄 Motivation and Context
In some scenarios, users may want to visualise relationships beyond Gradle's built-in module model, i. e. external dependencies. By allowing a custom graph model to be provided, the plugin can now support these extended use cases without affecting existing functionality.
🧪 How Has This Been Tested?
README.md)📦 Types of changes
✅ Checklist