Conversation
…s `LOWER` and `UPPER`
Because some DBMS (at least MS-SQLServer) require the usage of ORDER BY when OFFSET is used, ADQL does to. It also guarantees the consistency of the result. The changelog has also been updated for OFFSET but also LOWER and UPPER.
and restructure a bit the changelog
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to make mandatory some well-approved and well-supported (by most DBMS used in implementations) features.
The concerned features are:
About
OFFSET, I have added a constraint since 2.1: it can not be used without anORDER BY.Two reasons:
ORDER BYwithOFFSET. Having also this constraint lets users of this DBMS be easily compatible with ADQL.About
ILIKE, it stays optional for now because not all DBMS (MySQL, SQLServer, Oracle) support it. One may say that it can be replaced byLOWER(col1) LIKE LOWER('...')but in term of performance (index) it may not be the same (although the same issue may happen withILIKEtoo depending on the search pattern). In brief, it may need discussions before becoming mandatory.Fixes #94