Conversation
I had used the term scope/scoping to signify the set of endpoints for which a permit was applicable. However "scope" has a different meaning within OAuth2, so this presented possibility for confusion. So this commit replaces non-OAuth2-related use of the term "scope" with "domain" instead. There is no change in the intent. I also removed a couple of domain-related todo notes that probably don't need to be there any more.
Member
Author
|
Related to this change: the term "domain-proxy check" is used in discusssion of Bearer Token handling. Since "domain-proxy" is not the same as "domain" I don't think that introduces too much confusion, but I don't understand where this term comes from (a quick google doesn't show it up used elsewhere) or what it means - e.g. what does "proxy" refer to here? @jesusjuansalgado if you can think of a better term than "domain-proxy check" maybe you could replace it with a commit to this PR, but if you're happy with it as it stands that's OK. Either way, could you review this hopefully uncontroversial PR. |
|
Close duplicate PR #19? |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had used the term scope/scoping to signify the set of endpoints for which a permit was applicable. However "scope" has a different meaning within OAuth2, so this presented possibility for confusion.
So this commit replaces non-OAuth2-related use of the term "scope" with "domain" instead. There is no change in the intent.
I also removed a couple of domain-related todo notes that probably don't need to be there any more.