Add base64url/utf16le encoding, Jest parity tests, and example app#1
Open
cybercarrot wants to merge 8 commits intoiwater:mainfrom
Open
Add base64url/utf16le encoding, Jest parity tests, and example app#1cybercarrot wants to merge 8 commits intoiwater:mainfrom
cybercarrot wants to merge 8 commits intoiwater:mainfrom
Conversation
Add JS-side encoding helpers for base64url, utf16le/ucs2, and ASCII so these paths no longer require native round-trips. Fix lastIndexOf bounds overflow, improve Buffer.from for typed arrays and Symbol.toPrimitive, and make concat respect totalLength truncation. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Bump react-native-nitro-modules peer dep from ^0.32.0 to ^0.35.0, add nitrogen as explicit devDependency, simplify build script, and configure ignorePaths in nitro.json to skip node_modules and example. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Fix podspec homepage and source pointing to wrong repo (rn-http-server), add repository/homepage/bugs fields to package.json, and include nitro.json in the files array so consumers get working autolinking. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add Node-environment Jest tests validating Buffer behavior against node:buffer, including core API, encoding edge cases, and utility functions. Include NitroModules mock backed by Node.js Buffer. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add standalone example app for real-device validation of the Nitro Buffer implementation, including smoke test cases and Maestro automation flows. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Revise API compatibility claims, add testing section and new encoding examples to both READMEs. Add repository guidelines (AGENTS.md) and Claude Code guidance (CLAUDE.md) for contributor onboarding. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Remove 12000+ files in example/ios/build-targeted/ that were accidentally committed. Add build-targeted/ to .gitignore. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
base64url,utf16le/ucs2, and ASCII decoding — eliminates unnecessary native round-trips for these encodingslastIndexOfbounds overflow, improveBuffer.fromfor typed arrays andSymbol.toPrimitive, makeconcatrespecttotalLengthtruncationhomepage/sourceURLs (previously pointed torn-http-server), addnitro.jsonto publishedfilesso consumers get working autolinkingreact-native-nitro-modulespeer dep from^0.32.0to^0.35.0, addnitrogenas explicit devDependency, configureignorePathsinnitro.jsonnode:buffer, with NitroModules mockAGENTS.mdandCLAUDE.mdTest plan
yarn test— all Jest parity tests passcd example && yarn ios— verify example app runs on iOS simulatorcd example && yarn android— verify example app runs on Android emulatorcd example && yarn test:e2e— Maestro smoke tests pass🤖 Generated with Claude Code