Add linter and guard, apply fixes and suppress by scope by WalterWoshid · Pull Request #49 · j-plugins/mago-plugin

WalterWoshid · 2026-02-11T16:33:47Z

Mago inspection now runs lint and guard together with analyze and shows all results in the editor. You can apply Mago autofixes from annotations and suppress issues by statement, function, method, or class. Fixes and suppress actions support intention preview (Ctrl+Q).

Changes

Linter and guard – When enabled in settings, the pipeline runs mago lint and mago guard in addition to analyze and merges problems into the same annotations. Lint and guard issues get the same apply-fix and suppress quick fixes as analyze.
Better descriptions
Apply fix – Apply a single Mago autofix from the problem annotation (Alt+Enter). Fix text uses issue help or message, prefixed with "Mago: ". Before there was a global "Mago: fix the whole file", which only ran the formatter. This has been removed.
Apply all by safety – Submenus: "Fix all (safe only)", "Fix all (potentially unsafe)", "Fix all (unsafe)". Each applies only that tier; apply-all uses in-memory edits (no CLI run) so undo works.
Mago: Suppress – Quick fix to add @mago-ignore category:code with options: for statement, for function, for method, for class. Submenu when multiple apply. Same-category codes merged into one comment.
Format after fix option - Runs the formatter after applying a fix.
Platform – Target PhpStorm (PS) 2025.3.2. Remove ReformatFileAction.

Some known bugs/problems/missing stuff

The edits are out of sync if Mago is still analyzing after applying an edit. This could be suppressed by removing all annotations until its done analyzing (ugly) or adjusting the edit positions (too much work) or displaying a warning "Please wait for Mago to finish before applying more edits"
Sometimes, not sure how to reproduce, the annotations are out of place until Mago is done analyzing.
When "format after fix" is run, then hitting the Undo action, PhpStorm asks "Undo Reload from Disk?" which is a slight inconvenience, because the formatter is ran externally. This could be solved by applying the fix on a temporary file, running the formatter on that temporary file, then applying the changes to the editor, without needing 2 actions at once.
Suppressing via @mago-ignore on a method or class that already has a PHPDoc will add a second PHPDoc, this should be fixed.

- Run mago lint and guard with analyze; merge results into annotations - Apply single fix or apply-all by safety (safe / potentially unsafe / unsafe) - After apply: clear problem cache and restart daemon to avoid stale fixes when applying again while Mago is re-analyzing (3–5 s) - Format after fix: run Mago formatter when the option is enabled in settings - Mago: Suppress for statement, function, method, class (submenu when multiple); always show "for statement" so narrowest scope is available - Intention preview (Ctrl+Q) for apply and suppress - Remove ReformatFileAction; fix DaemonCodeAnalyzer.restart deprecation

WalterWoshid · 2026-02-11T16:34:25Z

This Pull Request also makes #47 obsolete, because it is included.

xepozz

Thanks for improving the plugin, but let's make it a bit clear first

src/main/kotlin/com/github/xepozz/mago/qualityTool/MagoMessageProcessor.kt

xepozz · 2026-02-12T16:26:02Z

src/main/kotlin/com/github/xepozz/mago/qualityTool/MagoMessageProcessor.kt

-        val charStart = String(bytes.copyOf(byteStart), Charsets.UTF_8).length
-        val charEnd = String(bytes.copyOf(byteEnd), Charsets.UTF_8).length
-        return charStart until charEnd
+    private fun runExtraTool(


please create a separate class containing all this run logic
together with the lines above that decide to run additional tools

this message processor should not run additional tools.

in general, "quality tools" API looks overcomplicated to implement mago features. you partially implemented some kind of raw quality tool, so I'd suggest you to complete this step and remove all "quality tool" api. would you like to do it?

xepozz · 2026-02-12T16:26:22Z

src/main/kotlin/com/github/xepozz/mago/qualityTool/MagoMessageProcessor.kt

+                }
+            }
+        } catch (_: Exception) {
+            // Ignore errors for individual tools


add "debug logger" here

xepozz · 2026-02-12T16:27:36Z

src/main/kotlin/com/github/xepozz/mago/qualityTool/MarkIgnoreAction.kt

+import com.jetbrains.php.lang.psi.elements.Method

-class MarkIgnoreAction(val code: String, val line: Int) : IntentionAction {
+class MagoIgnoreSubmenuAction(


please keep 1 class in 1 file

xepozz · 2026-02-12T16:40:19Z

src/main/kotlin/com/github/xepozz/mago/qualityTool/MagoApplyEditAction.kt

+    else -> 0
+}
+
+fun MagoEdit.maxSafetyLevel(): Int = replacements.maxOfOrNull { safetyLevel(it.safety) } ?: 0


put maxSafetyLevel in the MagoEdit instead

xepozz · 2026-02-12T16:42:00Z

src/main/kotlin/com/github/xepozz/mago/qualityTool/MagoApplyEditAction.kt

+        val maxSafetyValue = edits.flatMap { it.replacements }.maxOfOrNull { safetyLevel(it.safety) } ?: 0
+        val safetySuffix = when (maxSafetyValue) {
+            2 -> " (unsafe)"
+            1 -> " (potentially unsafe)"
+            else -> ""
+        }
+        return when {
+            !fixDescription.isNullOrBlank() -> "Mago: " + fixDescription.trim() + safetySuffix
+            isApplyAll -> "Mago: Apply all suggested fixes$safetySuffix"
+            else -> "Mago: Apply suggested fix$safetySuffix"
+        }
+    }


use string builder instead

xepozz · 2026-02-12T20:04:02Z

src/main/kotlin/com/github/xepozz/mago/qualityTool/MagoHtmlAnnotator.kt

+
+        /** Clear cached problems for this file so no fix is offered until the next Mago run. */
+        fun clearProblemCache(file: PsiFile) {
+            file.putUserData(MAGO_HTML_LAST_PROBLEMS, null)


add another function where you put and read there data

xepozz · 2026-02-12T20:07:27Z

src/main/kotlin/com/github/xepozz/mago/qualityTool/MagoHtmlAnnotator.kt

+        file.putUserData(MAGO_HTML_LAST_PROBLEMS, problems)
+    }
+
+    private fun formatGroupedHtmlMessage(problems: List<MagoProblemDescription>): String {


use buildString

xepozz · 2026-02-12T20:08:16Z

src/main/kotlin/com/github/xepozz/mago/qualityTool/MagoHtmlAnnotator.kt

+        return AnnotationResult(problems)
+    }
+
+    override fun apply(file: PsiFile, annotationResult: AnnotationResult, holder: AnnotationHolder) {


decompose this method

WalterWoshid · 2026-02-12T20:28:58Z

Thanks for the review, will do that tommorow :)

WalterWoshid added 2 commits February 11, 2026 13:18

chore: target PhpStorm (PS) 2025.3.2

1402c21

WalterWoshid force-pushed the feat/apply-fix-and-suppress branch from 654e856 to 3a848ce Compare February 12, 2026 14:21

xepozz requested changes Feb 12, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add linter and guard, apply fixes and suppress by scope#49

Add linter and guard, apply fixes and suppress by scope#49
WalterWoshid wants to merge 2 commits intoj-plugins:mainfrom
WalterWoshid:feat/apply-fix-and-suppress

WalterWoshid commented Feb 11, 2026

Uh oh!

WalterWoshid commented Feb 11, 2026

Uh oh!

xepozz left a comment

Uh oh!

Uh oh!

Uh oh!

xepozz Feb 12, 2026

Uh oh!

xepozz Feb 12, 2026

Uh oh!

xepozz Feb 12, 2026

Uh oh!

xepozz Feb 12, 2026

Uh oh!

xepozz Feb 12, 2026

Uh oh!

xepozz Feb 12, 2026

Uh oh!

xepozz Feb 12, 2026

Uh oh!

xepozz Feb 12, 2026

Uh oh!

WalterWoshid commented Feb 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

WalterWoshid commented Feb 11, 2026

Changes

Some known bugs/problems/missing stuff

Uh oh!

WalterWoshid commented Feb 11, 2026

Uh oh!

xepozz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

WalterWoshid commented Feb 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants