Open
Conversation
Owner
|
Sorry for the delay on this. If you can break these into individual PRs then I'll take them but I don't like to mix issues. I'm also happy to split them up myself. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- Bug fixed :
` file.length does not send an Exception if the file does not exist but 0L. Then, when the file does not exist, ContentInfo.EMPTY_INFO is returned. I added a condition to check the file is well readable (if it is readable then it exists).I found a small problem in your code. It seems that no exception was send when a file was given as parameter of util.findMatch(...). Here is the problem in your code
`
Feature
I added the following method
public ContentInfo findMatch(final URL url) throws IOExceptionMagic number
I added the magic number for VOTABLE (http://www.ivoa.net/documents/VOTable/), XSD (I did not find a mime type), OGG (I do not know how to make the difference between sound and video)
MimeType
I added the mime type for netcdf (I was not written with the magic number expression)