More matroska support and .TS mpeg support#69
Open
gandji wants to merge 3 commits intoj256:masterfrom
Open
Conversation
emretanriverdi
approved these changes
Oct 3, 2020
j256
reviewed
Oct 5, 2020
Owner
j256
left a comment
j256
left a comment
There was a problem hiding this comment.
Can you revert the change to the magic.gz? Add it instead as lines to the src/test/resources/magic file.
| */ | ||
| private FileType[] fileTypes = new FileType[] { // | ||
| // | ||
| new FileType("/files/x.mkv", ContentType.MATROSKA, "matroska", "video/x-matroska", |
Owner
There was a problem hiding this comment.
Can you move this to the end of the list? I'd like to keep these in time order.
Owner
|
Thanks for this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I love and use simplemagic, brings some of the power of linux to java.
For my own projects I added the file types I needed (in magic.gz file):
I added 2 unit tests with small files.
Integration in official simplemagic would make my life easier maintenance-wise.
Cheers,
G.