Fix misuse of constants - #2950
Open
riccardobl wants to merge 1 commit into
Open
Conversation
JNightRider
reviewed
Sep 5, 2026
| quadrant = ic.readShort("quadrant", (short)0); | ||
| stepScale = (Vector3f) ic.readSavable("stepScale", Vector3f.UNIT_XYZ); | ||
| offset = (Vector2f) ic.readSavable("offset", Vector3f.UNIT_XYZ); | ||
| offset = (Vector2f) ic.readSavable("offset", Vector2f.ZERO); |
Contributor
There was a problem hiding this comment.
Won't this case represent a radical change? After all, the value used to be (1, 1, 1), whereas now it is (0, 0, 0)
Member
Author
There was a problem hiding this comment.
This was likely a bug, because the writer defaults to ZERO
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes several cases of constants misuse that could end up being mutated, and one case where the code used the wrong constant.
Since passing references is often intentional in jme, I made sure to clone objects only when passing a reference was already causing the internal state to break.