updated main.js#2
Open
carvelhallndi wants to merge 2 commits into
Open
Conversation
…a barebones page is now being rendered using the jspm/es6 module technology
| jspm install fetch | ||
| jspm dl-loader --latest | ||
| npm install uglifyjs | ||
| npm install html-dist |
Owner
There was a problem hiding this comment.
all these dependencies should be in the package.json and then the install is just npm install && ./node_modules/.bin/jspm install
Owner
|
Thanks for this, but I don't understand why some of the changes have been made, hence the comments. Could you clarify? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
React.render() is deprecated and as a result, the example was broken. I just updated main.js to use ReactDOM.render and now it is good to go. Great code! Thanks for sharing.