refactor(xiaohongshu): replace blind retry with MutationObserver wait#730
Merged
refactor(xiaohongshu): replace blind retry with MutationObserver wait#730
Conversation
Instead of retrying the entire navigation when search results are empty, use a MutationObserver to wait for `section.note-item` elements (or login wall text) to appear in the DOM, with a 5s timeout. This is faster (resolves as soon as content renders) and more correct (addresses the root cause of delayed hydration rather than working around it with a full re-navigation).
WAIT_FOR_CONTENT_JS now returns 'content', 'login_wall', or 'timeout' instead of just true/false. This eliminates the separate login-wall evaluate call and the redundant loginWall field in the extraction payload. Two evaluate calls total (wait + extract) instead of three.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fetchAttempt()+ full re-navigation retry from PR fix(xiaohongshu): retry once when first pass returns empty results #681 with a MutationObserver-based waitsection.note-itemor login wall text to appear in the DOM (5s timeout), resolving as soon as content renderspage.wait()before checking content, no 6-7s retry pathTest plan
tsc --noEmitpasses