Only check for overlaps in pairs that we haven't already checked: Attempt 2#14
Merged
james-d-mitchell merged 0 commit intoApr 27, 2026
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## improve-knuth-bendix-2-squash #14 +/- ##
================================================================
Coverage ? 90.44%
================================================================
Files ? 184
Lines ? 22078
Branches ? 2666
================================================================
Hits ? 19968
Misses ? 2110
Partials ? 0
|
james-d-mitchell
merged commit ef616da
into
james-d-mitchell:improve-knuth-bendix-2-squash
45 of 60 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is almost identical to #13, now that rebase-conflicts have been resolved. I've also fixed some of the comments I had accidentally messed up in the previous PR, and added some new comments too.