Connection status issue #2519#2550
Closed
pgScorpio wants to merge 26 commits into
Closed
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the first stage I just renamed some functions in CClient to make the problem clear.
The second stage should already solve this issue.
Short description of changes
First Stage: Make the cause of the problem clear.
Second Stage:
Moved Connect/Disconnect code from CClientdlg to CClient.
Now using the proper connected checks in several places.
Added bDisconnectAndDisable to CChannel. (For a Client now
Channel.Disconnect() will block audio data and auto disable the channel on disconnected)
CHANGELOG:
Fix for issue #2519
Context: Fixes an issue?
fixes issue #2519
Does this change need documentation? What needs to be documented and how?
No documentation changes.
Status of this Pull Request
What is missing until this pull request can be merged?
Checklist