Skip to content

Connection status issue #2519#2550

Closed
pgScorpio wants to merge 26 commits into
jamulussoftware:mainfrom
pgScorpio:connect-issue-2519
Closed

Connection status issue #2519#2550
pgScorpio wants to merge 26 commits into
jamulussoftware:mainfrom
pgScorpio:connect-issue-2519

Conversation

@pgScorpio
Copy link
Copy Markdown
Contributor

@pgScorpio pgScorpio commented Mar 25, 2022

In the first stage I just renamed some functions in CClient to make the problem clear.
The second stage should already solve this issue.

Short description of changes

First Stage: Make the cause of the problem clear.

Second Stage:
Moved Connect/Disconnect code from CClientdlg to CClient.
Now using the proper connected checks in several places.
Added bDisconnectAndDisable to CChannel. (For a Client now
Channel.Disconnect() will block audio data and auto disable the channel on disconnected)

CHANGELOG:
Fix for issue #2519

Context: Fixes an issue?

fixes issue #2519

Does this change need documentation? What needs to be documented and how?

No documentation changes.

Status of this Pull Request

What is missing until this pull request can be merged?

Checklist

  • [x ] I've verified that this Pull Request follows the general code principles
  • [x ] I tested my code and it does what I want
  • [x ] My code follows the style guide
  • [x ] I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
  • [x ] I've filled all the content above

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants