Skip to content

Fixes 3880: Bump Dependencies retrieved empty jom version - #3881

Open
pljones wants to merge 1 commit into
jamulussoftware:mainfrom
pljones:fix-bump-dependencies-choco-jom
Open

Fixes 3880: Bump Dependencies retrieved empty jom version#3881
pljones wants to merge 1 commit into
jamulussoftware:mainfrom
pljones:fix-bump-dependencies-choco-jom

Conversation

@pljones

@pljones pljones commented Aug 9, 2026

Copy link
Copy Markdown
Collaborator

Short description of changes

Note

AI Authored change
(ridiculous amount of effort but at least it knew where to look, which I didn't)
Human tested

Bump Dependencies retrieved empty jom version. This changes the method of version retrieval and successfully retrieves a version.

CHANGELOG: SKIP

Context: Fixes an issue?

Fixes #3880

Does this change need documentation? What needs to be documented and how?

No.

Status of this Pull Request

Tested the old command against the new command:

$ echo "Old: {$(curl -s -o /dev/null --location --range 0-5 --write-out '%{url_effective}' https://community.chocolatey.org/api/v2/package/jom/ | grep -oP 'jom\.\K.*(?=\.nupkg)')}"
Old: {}
$ echo "New: {$(curl -sL "https://community.chocolatey.org/api/v2/FindPackagesById()?id='jom'" | grep -oP '(?<=<d:Version>)[^<]+' | sort --version-sort | tail -n1)}"
New: {1.1.2}

Merge to main on pljones/jamulus (failure is unrelated to this bug - it's expected behaviour on a non-jamulussoftware repo):
https://github.com/pljones/jamulus/actions/runs/31321765594/job/93265754130

What is missing until this pull request can be merged?

Review.

Checklist

  • I've verified that this Pull Request follows the general code principles
  • I tested my code and it does what I want
  • My code follows the style guide
  • I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
  • I've filled all the content above

@pljones
pljones force-pushed the fix-bump-dependencies-choco-jom branch from df199d8 to 4f78735 Compare August 9, 2026 15:45
@pljones pljones self-assigned this Aug 9, 2026
@pljones pljones linked an issue Aug 9, 2026 that may be closed by this pull request
@pljones pljones added this to the Release 4.0.0 milestone Aug 9, 2026
@pljones pljones added this to Tracking Aug 9, 2026
@github-project-automation github-project-automation Bot moved this to Triage in Tracking Aug 9, 2026
@pljones pljones added bug Something isn't working AI AI generated or potentially AI generated labels Aug 9, 2026
@pljones pljones moved this from Triage to Waiting on Team in Tracking Aug 9, 2026
@pljones
pljones requested review from ann0see and softins and a lite review from Copilot August 9, 2026 15:51

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the “choco-jom” upstream version detection in the dependency bump workflow by switching from a redirect-based URL sniff to querying Chocolatey’s OData feed and extracting the latest <d:Version> value.

Changes:

  • Replace the previous url_effective + regex extraction approach for jom with FindPackagesById and XML tag parsing.
  • Sort returned versions using sort --version-sort and select the latest with tail -n1.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread .github/workflows/bump-dependencies.yml
get_upstream_version: |
curl -s -o /dev/null --location --range 0-5 --write-out '%{url_effective}' https://community.chocolatey.org/api/v2/package/jom/ |
grep -oP 'jom\.\K.*(?=\.nupkg)'
curl -sL "https://community.chocolatey.org/api/v2/FindPackagesById()?id='jom'" |

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugly, but if that's how it works, fine.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm... yeah, this might be better

$ curl -s 'https://community.chocolatey.org/api/v2/FindPackagesById()?id=%27jom%27' | yq -p xml '.feed.entry[0].id'

which gives

http://community.chocolatey.org/api/v2/Packages(Id='jom',Version='1.1.2')

but depends on yq.

@softins softins left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested the commands one at a time to see the output, and this seems to work fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI AI generated or potentially AI generated bug Something isn't working

Projects

Status: Waiting on Team

Development

Successfully merging this pull request may close these issues.

Bump Dependencies fails with "choco-jom" error

4 participants