Fixes 3880: Bump Dependencies retrieved empty jom version - #3881
Open
pljones wants to merge 1 commit into
Open
Conversation
pljones
force-pushed
the
fix-bump-dependencies-choco-jom
branch
from
August 9, 2026 15:45
df199d8 to
4f78735
Compare
pljones
requested review from
ann0see and
softins
and
a lite review from Copilot
August 9, 2026 15:51
There was a problem hiding this comment.
Pull request overview
This PR fixes the “choco-jom” upstream version detection in the dependency bump workflow by switching from a redirect-based URL sniff to querying Chocolatey’s OData feed and extracting the latest <d:Version> value.
Changes:
- Replace the previous
url_effective+ regex extraction approach forjomwithFindPackagesByIdand XML tag parsing. - Sort returned versions using
sort --version-sortand select the latest withtail -n1.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
ann0see
reviewed
Aug 9, 2026
ann0see
reviewed
Aug 9, 2026
| get_upstream_version: | | ||
| curl -s -o /dev/null --location --range 0-5 --write-out '%{url_effective}' https://community.chocolatey.org/api/v2/package/jom/ | | ||
| grep -oP 'jom\.\K.*(?=\.nupkg)' | ||
| curl -sL "https://community.chocolatey.org/api/v2/FindPackagesById()?id='jom'" | |
Member
There was a problem hiding this comment.
Ugly, but if that's how it works, fine.
Collaborator
Author
There was a problem hiding this comment.
Hm... yeah, this might be better
$ curl -s 'https://community.chocolatey.org/api/v2/FindPackagesById()?id=%27jom%27' | yq -p xml '.feed.entry[0].id'
which gives
http://community.chocolatey.org/api/v2/Packages(Id='jom',Version='1.1.2')
but depends on yq.
softins
approved these changes
Aug 9, 2026
softins
left a comment
Member
There was a problem hiding this comment.
I've tested the commands one at a time to see the output, and this seems to work fine.
ann0see
approved these changes
Aug 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description of changes
Note
AI Authored change
(ridiculous amount of effort but at least it knew where to look, which I didn't)
Human tested
Bump Dependencies retrieved empty jom version. This changes the method of version retrieval and successfully retrieves a version.
CHANGELOG: SKIP
Context: Fixes an issue?
Fixes #3880
Does this change need documentation? What needs to be documented and how?
No.
Status of this Pull Request
Tested the old command against the new command:
Merge to main on pljones/jamulus (failure is unrelated to this bug - it's expected behaviour on a non-jamulussoftware repo):
https://github.com/pljones/jamulus/actions/runs/31321765594/job/93265754130
What is missing until this pull request can be merged?
Review.
Checklist