scratch: asset holder - #1
Closed
janicduplessis wants to merge 1 commit into
Closed
janicduplessis wants to merge 1 commit into
janicduplessis wants to merge 1 commit into
Conversation
experimental_flushSync now carries the surface of the emitter that requested it (from the ShadowNodeFamily every emitter is given at creation) through EventDispatcher and EventQueue to EventBeat::requestSynchronous, as an optional: without a surface the induce falls back to the run loop observer's ordinary schedule. AppleEventBeat resolves the surface to its root view's layer via a resolver injected by RCTSurfacePresenter from the surface registry, and attaches the flusher layer there instead of to every visible window. A request made from layout runs inside the commit of exactly that tree, so the layer is guaranteed a display phase in the same cycle without assuming all windows commit in one transaction. VirtualView's sync flushes get the same targeting through its own emitter, unchanged.
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
holds the capture for react#58528
proto-capture.mp4