Skip to content

Remove type field from sync scripts #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Alexanderamiri merged 1 commit into from
Mar 26, 2026
Merged

Remove type field from sync scripts #102

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion scripts/provision-groups.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,6 @@ def build_member_details(members_data):
"firstname": h["firstname"],
"lastname": h["lastname"],
"personal_email": h["personal_email"],
"type": h.get("type", "helt"),
"alias": h.get("alias") or "",
}
for h in members_list
Expand Down
8 changes: 1 addition & 7 deletions scripts/sync-members.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,12 +220,8 @@ def format_yaml(members):
"# Board approves applications in the Google Sheet, then triggers a sync that",
"# creates a PR updating this file.",
"#",
"# Two member types:",
"# - helt: Approved hero volunteer (full access: email, drive, chat, meet)",
"# - aktiv: Active contributor (java.no account for SSO, calendar, groups only)",
"#",
"# Rules:",
"# - type determines baseline access (see groups/access.yaml)",
"# - All group memberships are explicit (including helter)",
"# - memberships references group names from groups.yaml",
"# - alias is optional — members can PR their preferred alias",
"# - javabin_google_email is the Google Workspace account (firstname.lastname@java.no)",
Expand All @@ -242,7 +238,6 @@ def format_yaml(members):
lines.append(f" lastname: {m['lastname']}")
lines.append(f" personal_email: {m['personal_email']}")
lines.append(f" javabin_google_email: {m['javabin_google_email']}")
lines.append(f" type: {m.get('type', 'helt')}")
alias = m.get("alias") or ""
lines.append(f" alias: {alias}" if alias else " alias:")
memberships = m.get("memberships", [])
Expand Down Expand Up @@ -363,7 +358,6 @@ def main():
"lastname": lastname,
"personal_email": personal_email,
"javabin_google_email": javabin_email,
"type": "helt",
"alias": "",
"memberships": memberships,
}
Expand Down