Fix aws.javabin.no redirect to include /start path#115
Merged
Conversation
S3 redirect_all_requests_to only sets the hostname, dropping the path. Use a CloudFront Function instead to redirect to the full URL https://javabin.awsapps.com/start.
Terraform Plan🚧 Changes detected — Plan: 2 to add, 1 to change, 0 to destroy. Plan outputLLM ReviewRisk: 🟢 LOW Plan adds Cost and Usage Report export and updates CloudFront distribution with a new redirect function—routine infrastructure improvements with no security or data loss concerns.
|
Alexanderamiri
added a commit
that referenced
this pull request
May 9, 2026
## Summary - S3 `redirect_all_requests_to` only sets hostname, not path — redirected to `javabin.awsapps.com/` instead of `/start` - Adds CloudFront Function that returns 301 to `https://javabin.awsapps.com/start` - S3 bucket kept as dummy origin (CloudFront requires one) ## Test plan - [ ] `curl -I https://aws.javabin.no` returns `location: https://javabin.awsapps.com/start`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
redirect_all_requests_toonly sets hostname, not path — redirected tojavabin.awsapps.com/instead of/starthttps://javabin.awsapps.com/startTest plan
curl -I https://aws.javabin.noreturnslocation: https://javabin.awsapps.com/start