fix: carry the connection name onto builders created from a bound ins… - #5
Merged
Merged
Conversation
…tance
`connection()` clones the Stretch instance and swaps its client, but the
factories that build from it — `query()`, `index()`, `multi()`, `scroll()` —
forwarded only the client, never `connectionName`. The new builder therefore
reported the *default* connection.
Queries still reached the right cluster, so nothing failed loudly. What broke
was everything keyed on the name: the response cache key is namespaced by it,
so `Stretch::connection('b')->index('posts')` cached under connection `a` and
two connections holding an identically named index could serve each other's
hits.
Propagate the name through a `bindConnectionName()` setter. A protected
property cannot be assigned across unrelated classes even when both use the
trait, so the setter is public and marked `@internal`; `connection()` remains
the only way to *switch* a connection, which swaps the client too.
Found while tracing a favorites/pins search that reported connection
`infinity` in its cache key while configured for `microservices`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…tance
connection()clones the Stretch instance and swaps its client, but the factories that build from it —query(),index(),multi(),scroll()— forwarded only the client, neverconnectionName. The new builder therefore reported the default connection.Queries still reached the right cluster, so nothing failed loudly. What broke was everything keyed on the name: the response cache key is namespaced by it, so
Stretch::connection('b')->index('posts')cached under connectionaand two connections holding an identically named index could serve each other's hits.Propagate the name through a
bindConnectionName()setter. A protected property cannot be assigned across unrelated classes even when both use the trait, so the setter is public and marked@internal;connection()remains the only way to switch a connection, which swaps the client too.Found while tracing a favorites/pins search that reported connection
infinityin its cache key while configured formicroservices.