fix(core): distinguish upgrade readiness from advisories#138
Merged
Conversation
Release highlights: - keep retrieval ready after safe migrations when only privacy warnings remain Release details: - **Upgrade DX:** report security follow-ups as non-blocking advisories - **Continuity:** preserve strict doctor checks while avoiding unnecessary reindex loops Verification: - pass pnpm validate - verify both PAC indexes report current and ready with their advisories
|
🎉 This PR is included in version 2.19.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
After a successful upgrade and reindex, an operational project could still be labeled
repair-requiredwhen only an independent privacy warning remained. This encouraged unnecessary repair loops even though retrieval was healthy.What changed
privacyCompliantandadvisoriesseparately in text and JSON outputdoctorandsecurity-auditbehaviorUpgrade continuity
Older schemas, missing manifests, old configs, interrupted staged rebuilds, and advisory-only states are covered. Rebuilds remain isolated and atomically activated; a privacy advisory never hides a real compatibility failure.
Validation
pnpm validatepassedstatus=currentandready=truewhile preserving their exact advisories