bugfix: add ILU process group ctor for explicit local rank. (#1240)#1271
Open
liutongxuan wants to merge 2 commits intojd-opensource:mainfrom
Open
bugfix: add ILU process group ctor for explicit local rank. (#1240)#1271liutongxuan wants to merge 2 commits intojd-opensource:mainfrom
liutongxuan wants to merge 2 commits intojd-opensource:mainfrom
Conversation
…ource#1240) Add the ILU ProcessGroup constructor overload that accepts local_rank and explicit group_ranks, so the DiT process-group creation path matches the expected signature and builds successfully.
liutongxuan
requested review from
DongheJin,
JimHsiung,
RobbieLeung,
XuZhang99,
walsonyang and
yq33victor
as code owners
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new constructor for the ProcessGroupImpl class in ilu_process_group.h to support more granular configuration of NCCL process groups, including group naming for compatibility with newer PyTorch versions and custom rank mappings. The review feedback identifies style guide violations concerning the use of auto for primitive types and the preference for emplace_back over push_back when populating vectors.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
RobbieLeung
approved these changes
Apr 13, 2026
JimHsiung
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the ILU ProcessGroup constructor overload that accepts local_rank and explicit group_ranks, so the DiT process-group creation path matches the expected signature and builds successfully.