feat: update conv1d_update op for Qwen3-Next/Qwen3.5.#1291
Open
maojunx99 wants to merge 2 commits intojd-opensource:mainfrom
Open
feat: update conv1d_update op for Qwen3-Next/Qwen3.5.#1291maojunx99 wants to merge 2 commits intojd-opensource:mainfrom
maojunx99 wants to merge 2 commits intojd-opensource:mainfrom
Conversation
maojunx99
requested review from
DongheJin,
JimHsiung,
RobbieLeung,
XuZhang99,
liutongxuan,
walsonyang and
yq33victor
as code owners
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces the causal_conv1d_update_v2 kernel for NPU and updates the Qwen3GatedDeltaNetBase implementation. Key feedback includes correcting an erroneous transpose in the prefill path that impacts tensor narrowing, fixing a naming convention violation for local variables, and removing a redundant batch variable. Additionally, a reshape operation in the decode path needs to be corrected to ensure the kernel receives the expected tensor dimensions.
maojunx99
force-pushed
the
main
branch
2 times, most recently
from
53ed5d5 to
a6ee25d
Compare
yingxudeng
reviewed
Apr 16, 2026
yingxudeng
changed the title
yingxudeng
reviewed
Apr 16, 2026
yingxudeng
reviewed
Apr 16, 2026
maojunx99
force-pushed
the
main
branch
2 times, most recently
from
3e67b12 to
5afd0de
Compare
zhang-minchao
previously approved these changes
Apr 17, 2026
yingxudeng
previously approved these changes
Apr 17, 2026
DongheJin
previously approved these changes
Apr 17, 2026
maojunx99
dismissed stale reviews from DongheJin, yingxudeng, and zhang-minchao
via
ab4ed2e
yingxudeng
previously approved these changes
Apr 18, 2026
zhang-minchao
previously approved these changes
Apr 18, 2026
maojunx99
dismissed stale reviews from zhang-minchao and yingxudeng
via
623a1e9
yingxudeng
previously approved these changes
Apr 19, 2026
yingxudeng
approved these changes
Apr 20, 2026
DongheJin
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates depend on the operator library: https://gitcode.com/xLLM-AI/torch_npu_ops/pull/13