feat: reuse pre-planned ExecCfg in sparse MoE prep_in.#1297
Open
yq33victor wants to merge 1 commit intojd-opensource:mainfrom
Open
feat: reuse pre-planned ExecCfg in sparse MoE prep_in.#1297yq33victor wants to merge 1 commit intojd-opensource:mainfrom
yq33victor wants to merge 1 commit intojd-opensource:mainfrom
Conversation
Signed-off-by: pengtao <pengtao.156@jd.com>
yq33victor
requested review from
DongheJin,
JimHsiung,
RobbieLeung,
XuZhang99,
liutongxuan and
walsonyang
as code owners
yq33victor
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the prep_in method within the DeepseekV2SparseMoEBlockImpl class to accept an explicit execution configuration (ExecCfg) as an argument, rather than calculating it internally via plan_exec. This change is reflected in the DeepseekV2DecoderLayerImpl and the corresponding unit tests, which now include a new test case verifying that prep_in correctly uses the provided configuration. Additionally, minor formatting and whitespace cleanup were performed in phy_page_pool.h and xtensor.cpp. I have no feedback to provide as there were no review comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.