bugfix: clarify linear state cache allocation failure message.#1302
Open
Kang-Meng wants to merge 1 commit intojd-opensource:mainfrom
Open
bugfix: clarify linear state cache allocation failure message.#1302Kang-Meng wants to merge 1 commit intojd-opensource:mainfrom
Kang-Meng wants to merge 1 commit intojd-opensource:mainfrom
Conversation
Kang-Meng
requested review from
DongheJin,
JimHsiung,
RobbieLeung,
XuZhang99,
liutongxuan,
walsonyang and
yq33victor
as code owners
XuZhang99
changed the title
XuZhang99
approved these changes
Apr 17, 2026
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a validation check in LLMEngine::estimate_kv_cache_capacity to ensure that the linear state cache can be reserved when linear_slot_size is greater than zero. It adds a CHECK_GT assertion that provides a descriptive error message and a suggested limit for max_seqs_per_batch if the reservation fails. I have no feedback to provide.
RobbieLeung
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.