[JENKINS-30141] Option to choose if depth is sticky

[vvv444]

https://issues.jenkins-ci.org/browse/JENKINS-30141

User can choose the desired behavior now (like --depth and --set-depth flags in svn)

[jenkinsadmin]

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

[oleg-nenashev]

binary compatibility issue. It's better to keep and deprecate the original constructor

[vvv444]

Thank you! I'm quite new to Java :-)
I've pushed a fix commit to my repository. Now, how is it customary to
proceed in such cases? Shall I open a new pull request?

On Wed, Sep 9, 2015 at 12:32 PM, Oleg Nenashev notifications@github.com
wrote:

In src/main/java/hudson/scm/SubversionSCM.java
#134 (comment)
:

     }

     @DataBoundConstructor

•    public ModuleLocation(String remote, String credentialsId, String local, String depthOption, boolean ignoreExternalsOption) {
  

•    public ModuleLocation(String remote, String credentialsId, String local, String depthOption, boolean stickyDepth, boolean ignoreExternalsOption) {
  

binary compatibility issue. It's better to keep and deprecate the original
constructor

—
Reply to this email directly or view it on GitHub
https://github.com/jenkinsci/subversion-plugin/pull/134/files#r39023278.

[oleg-nenashev]

Could you also create a help file for this new option?

[vvv444]

Sure. Done :-)

[recena]

@vvv444 Please, use <code> instead of <tt>. I'll try to merge this PR soon.

[vvv444]

done

[vvv444]

Please note the check failed due to some timeout problem. Not because of my code. How can I rerun it?

[recena]

@vvv444 close and open the PR.

[vvv444]

@recena @oleg-nenashev Hey guys, any reason why this wasn't integrated?

[recena]

@vvv444 Yes, I'm avoiding to include new features until we improve our test coverage and solve bugs related to svn:externals. I'm sorry for that.

[jglick]

I would also prefer to avoid new features unless they are obviously self-contained like SCMBrowsers.

[rshah88]

Hey guys, any ETA on when will this feature be integrated ?

[oleg-nenashev]

Somebody need to resolve the merge conflict