Fix ToInt64RoundZero edge cases, add Sin/Cos/Tan and tests, update README#6
Merged
Fix ToInt64RoundZero edge cases, add Sin/Cos/Tan and tests, update README#6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
ToInt64RoundZeroconversion for edge cases and shifting semantics.Sin,Cos,Tan) for theX80type to broaden the math API.Description
ToInt64RoundZeroinconversions.goby reordering the overflow/edge-case branch, returningmath.MinInt64for the exact negative-int64 boundary, adjusting the shift to avoid sign-extension (aSig >> (-shiftCount)), and ensuring exceptions are raised correctly.Sin,Cos, andTanmethods tooperations.gothat return NaN for NaN inputs and otherwise call the standard library viamath.Sin,math.Cos, andmath.Tanwith conversions to/fromfloat64.mathwhere required and updated tests: addedTestX80_ToInt64RoundZeroandTestX80_SinCosTaninconversions_test.goandoperations_test.gorespectively to validate behavior and NaN/Infinity handling.readme.mdto document the new trig methods and the round-toward-zero conversion variants (ToInt32RoundZero,ToInt64RoundZero).Testing
go test ./...covering conversions and operations includingTestX80_ToInt64RoundZeroandTestX80_SinCosTan.Codex Task