Conversation
…sic and Direct Plugin Removed: - Zero-config FlexPack branch from GradleCmd - Native mode detection and routing for Gradle - resolveServer helper function (only used for FlexPack) Keeping only: - Classic path: jf gradle (via init-script) - Direct Plugin: apply plugin in build.gradle This simplifies the Gradle execution model and reduces complexity.
…ic and Direct Plugin Removed: - runWithGradleNative() function from GradleCommand - extractBuildFilePath() helper function - FlexPack collections code via flexpackgradle package - Entire artifactory/commands/flexpack/gradle/ directory - Tests for extractBuildFilePath (106 lines) - FlexPack import statements Keeping only: - Classic path: init-script via jf gradle - Direct Plugin: apply plugin in build.gradle The Direct Plugin via ArtifactoryPlugin handles buildSrc/composite builds directly without needing FlexPack.
- Added includeSharedBuild flag definition in commandsflags.go - Flag enables shared build collection (buildSrc, composite builds) when using gradle command - Updated GradleCmd in cli.go to extract and pass flag to gradle execution - Updated help documentation for gradle command - Enables testing of classic init script approach: jf gradle build --include-shared-build The flag routes through to the Gradle build system which uses the init script to apply the artifactory plugin and collect shared build metadata. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
udaykb2
changed the title
udaykb2
marked this pull request as ready for review
September 15, 2026 09:32
udaykb2
requested review from
a team,
agrasth,
bhanurp,
fluxxBot,
itsmeleela and
reshmifrog
and removed request for
a team
September 15, 2026 09:32
--include-shared-build is only supported with Gradle Classic today. In the FlexPack/native path (no gradle-config file), the flag was never stripped from the task args, so it silently reached the real gradle binary as an unrecognized argument and failed the build with a confusing error. Extract and explicitly reject it with a clear message instead.
udaykb2
added
the
safe to test
Contributor
build-info-go and jfrog-cli-artifactory local dev replaces serve no purpose commented out - local development already goes through the go.work at the parent directory. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Follows the removal of the redundant ExtractIncludeSharedBuildFromArgs wrapper in jfrog-cli-core. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
includeSharedBuild was grouped under "Unique gradle-config flags" but is only wired into commandFlags[Gradle] (the runtime jf gradle flag), not commandFlags[GradleConfig]. Moved it to its own comment block so the categorization isn't misleading. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
The Gotchas section didn't mention that this flag errors out in Gradle FlexPack (native) mode, which has no gradle-config file. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
masterbranch.go vet ./....go fmt ./....Summary
--include-shared-buildto classicjf gradle.jfrog-cli-artifactory.