Catch and log exceptions from failed links#8
Open
shurickdaryin wants to merge 2 commits intojgunthorpe:masterfrom
Open
Catch and log exceptions from failed links#8shurickdaryin wants to merge 2 commits intojgunthorpe:masterfrom
shurickdaryin wants to merge 2 commits intojgunthorpe:masterfrom
Conversation
Owner
|
Thank you for the patch, What scenarios were you able to use this in? There are many reasons a SMP send during discovery could fail, this seems to deal with the forward direction failing - is that because a SMA is non-responsive or similar? I would think the most common reason would be a change in the already discovered region - ie a link going down? |
Author
|
This helps in two cases observed in our practice:
In both cases python-rdma's discovery does not finish due to exceptions. On the contrary, standard tools like ibnetdiscover do finish while reporting observed errors. Results of discovery with proposed patch are consisted with those of ibnetdiscover. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I propose to add simple exception handlers for failed links, so that discovery can finish in their presence.