Remove mis-uses of UNREACHABLE_RETURN - #22
Merged
Merged
Conversation
Ref: msgpack/msgpack-ruby#398 `UNREACHABLE_RETURN()` happen to work on clang and gcc, but fails on some other compilers like msvc. Either way, it's not really useful because `rb_raise` is declared as `noreturn` so I suspect the compiler can already tell this point is unreachable.
byroot
force-pushed
the
unreachable-return
branch
3 times, most recently
from
September 11, 2026 08:13
086c255 to
1016c72
Compare
Otherwise there's no version of minitest that support all the same ruby versions we do.
byroot
force-pushed
the
unreachable-return
branch
from
September 11, 2026 08:18
1016c72 to
b2ddc51
Compare
|
🙏 Thanks! I will try to build this with mswin platform. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: msgpack/msgpack-ruby#398
UNREACHABLE_RETURN()happen to work on clang and gcc, but fails on some other compilers like msvc.Either way, it's not really useful because
rb_raiseis declared asnoreturnso I suspect the compiler can already tell this point is unreachable.FYI: @hsbt