This repository was archived by the owner on Oct 11, 2018. It is now read-only.
Open
Conversation
added 6 commits
February 25, 2017 22:34
All tested with Debian Jessie and Stretch. Most likely broke for RedHat based systems (but this module was probably broke for RedHat systems already - Feel free to extend). Signed-off-by: Henry Paulissen <henry@nitronetworks.nl>
Signed-off-by: Henry Paulissen <henry@telegraafnet.nl>
Signed-off-by: Henry Paulissen <henry@nitronetworks.nl>
Stretch seems to use php7.0- prefix for extensions shipped with php7.0 and php- prefix for other php extensions. I updated the code to reflect this. Cross checked Jessie, every package on there is prefixed with php5-. Signed-off-by: Henry Paulissen <henry@telegraafnet.nl>
In Jessie the php-apc is a virtual package for php5-apcu. In Stretch this package is named php-apcu and as last, for Wheezy we want to install the real php-apc. So I added more conditionals in the apc package. Signed-off-by: Henry Paulissen <henry@telegraafnet.nl>
All "7.0" in puppet code should be gone now. Signed-off-by: Henry Paulissen <henry@telegraafnet.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed most (if not all) hardcoded php version numbers into case statements.
This way the module will be compatible with php5 and other distro's while keeping
compatible with the new php7.0 and possible future upgrades.
** Tested package names & version numbers only for Debian Jessie and Stretch.