Repository navigation
feat(ai-review): isolate analysis from validated GitHub publishing - #14
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Codex currently posts directly to GitHub with a write-capable App token. Split analysis from publication so the model returns structured findings under read-only GitHub permissions, and a fresh runner validates and publishes the result.
The publisher requires an explicit completed review for the exact SHA, validates paths and inline ranges against the rename-aware Git diff, deduplicates its own finding markers, and rechecks that the PR is open, non-draft, and still at the reviewed head immediately before posting. Native PR reviews retain
APPROVEwith inline findings; commit mode retains a single consolidated comment. Invalid, missing, incomplete, stale, or failed output fails the workflow instead of being treated as an empty review.Intentional decisions and tradeoffs
gpt-5.6-terra), effort, CLI/action pins, review scope, and approval convention remain unchanged. Incremental review belongs to PR 3.commit_idpins the review to the inspected SHA across that narrow race.Validation
python3 -m unittest discover -s tests -v: 21 tests passed, including malformed/missing/incomplete JSON, wrong SHA, invalid paths/ranges, deleted and renamed lines, duplicate/retried publication, stale/closed/draft PRs, and read/write API failures.actionlint1.7.7 andgit diff --check: passed.output-schemasupport; CLI 0.149.0exec --helpconfirms the underlying flag without changing the runtime pin.