Repository navigation
feat(ai-review): add incremental reviews and dry-run benchmarks - #15
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up pushes currently re-review the entire PR and execution settings are hardcoded. Select a compatible previously reviewed ancestor from trusted publisher coverage markers, and expose explicit model/effort/timeout/CLI inputs while preserving the production defaults.
Coverage requires the configured bot identity, matching commit_id, the same full PR merge base, and a profile hash of the prompt, settings, additional focus, and PR title/body. Missing or incompatible coverage, rewrites, and same-head reruns use the full diff. Only validated publication records coverage; dry runs and benchmarks never advance it.
Intentional decisions and tradeoffs
dry_runvalidates and archives without minting an App token or posting.benchmark_nativeimplies this behavior and additionally runs native review from a clean worktree and separate Codex home.jitsu-code-review[bot]; custom callers must configure their actual posting App identity. Plain APPROVE reviews do not count as coverage.Validation
python3 -m unittest discover -s tests -v: 33 tests passed, including fixup selection, rewrite/base/profile fallbacks, marker trust, explicit full review, API failures, incremental summary coordinates, split/retried publication, execution bounds, pricing, and benchmark invocation.actionlint1.7.7 andgit diff --check: passed.The README documents all inputs and a non-publishing newer-CLI benchmark command. Live workflow and candidate benchmark results will be checked on this PR.